Port add-on to Thunderbird 140+ MailExtension#94
Port add-on to Thunderbird 140+ MailExtension#94andrewboldi wants to merge 25 commits intoprotz:masterfrom
Conversation
|
@andrewboldi, you are a real hero! Thanks. I am looking forward to building the .xpi, install and use it again. |
|
You're welcome @sphh! (You can also thank Codex too :)) Just one thing. Note that if you've installed Thunderbird with a sandboxed environment (e.g. with Snap) (as I have), Thunderbird does not have access to Therefore, the preferred setup is to install a helper script as a user service with Alternatively (less preferred), you can start it with |
|
@andrewboldi: I just made and installed the xpi file and I do not get any LaTeX rendered in the message compose window. After switching on the debugging options, I get this error message:
Any idea how to solve it? BTW I use Betterbird instead of Thunderbird Original, if that makes any difference. |
|
@sphh Codex here, I just pushed a fix for this. Root cause: Could you pull the latest branch, rebuild ( |
|
With the commit 0e0aa37, Betterbird freezes when converting a LaTeX formula. I have to kill the whole Betterbird. |
|
ok sorry let me debug this further. just setup betterbird |
|
Ok I have tested this on both Thunderbird (via Snap) and Betterbird (via direct archive) and it's working. |
|
Hurray! The last commit works! 👏 There is just one ‘problem’: If you have switched on
when sending? |
|
Yes! By default it should be off now. (You can also disable this in the settings) |
|
Ok. But I am talking about the case, when it is switched on and you forget to delete the run report … |
|
I am Codex. I pushed commit 46fbdd8 to tb140-mailextension-port. Run reports are now removed from the compose body automatically in compose.onBeforeSend, so they are not sent even when logging is enabled. |
|
I am impressed!! Here is a list of issues, this PR would close:
|
|
I also believe, that it was possible to edit a formula inserted with |
|
And one final feature I was always looking for: Sometimes I forget to run LaTeXIt! before sending the message. It would be really great, if you get a warning when sending, if that's what you want to do. ADDED: This could work similar to the "Have you forgotten to add an attachment" warning. IMHO automatically running LaTeXIt! is not such a good idea, because sometimes you don't want to convert a formula, e.g. when you want to show, how something is done in LaTeX. Do you think, that the two of you could also implement this? 🙇 |
|
Haha you're welcome! Features added:
|
|
hi Andrew, thanks for the PR! @sphh do you have further comments on usability / feature parity with previous version / functionality? |
|
This is a huge PR. A few preliminary questions.
|
Beside the notes in #94 (comment), I can only say, that I am more than happy that @andrewboldi finally tackled the task to bring LaTexIt up to date! |
|
Thanks for the review. Answers to your questions:
I also addressed @sphh's latest dialog/options usability notes in fa663f1. |
|
Thanks @andrewboldi for considering my suggestions! Personally I have no more ideas (at the moment! 🤣) |
|
Haha yeah I'll try to use the extension a bit more over the next few days to think of more ideas. |
|
@protz: Is there anything which keeps you from merging this PR and push the add-on to Thunderbird? |


Summary
$...$/$$...$$expressions into inline PNG images from the compose windowtblatex.*preference migration and executable autodetection supportValidation
node --check background.jsnode --check compose/compose-script.jsnode --check ui/options.jsnode --check ui/insert.jsnode --check api/TBLatex/implementation.jsmakeNotes
\$\\frac{2}{3}\$and\$\$\\boxed{\\frac{34}{31}}\$\$.0in the new experiment renderer.